[SPARK-26499][SQL][FOLLOW-UP] Replace update with setByte for ByteType in JdbcUtils.makeGetter#26532
Closed
maropu wants to merge 1 commit into
Closed
[SPARK-26499][SQL][FOLLOW-UP] Replace update with setByte for ByteType in JdbcUtils.makeGetter#26532maropu wants to merge 1 commit into
update with setByte for ByteType in JdbcUtils.makeGetter#26532maropu wants to merge 1 commit into
Conversation
|
Test build #113818 has finished for PR 26532 at commit
|
Member
Author
|
retest this please |
HyukjinKwon
approved these changes
Nov 15, 2019
|
Test build #113826 has finished for PR 26532 at commit
|
Member
|
The test cases should be fixed as of 65a189c |
Member
|
retest this please |
Member
Author
|
Oh, nice! Thanks for the re-trigger. |
|
Test build #113841 has finished for PR 26532 at commit
|
|
Test build #4935 has finished for PR 26532 at commit
|
Member
|
Merged to master. The change was already in 2.4 from another related commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up pr to fix the code coming from #23400; it replaces
updatewithsetBytefor ByteType inJdbcUtils.makeGetter.Why are the changes needed?
For better code.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.